Skip to content

Docs & regression-test gaps left by recent PRs #3296

Description

@shaun0927

A few small follow-ups from recent PRs that mostly fall in the "good first issue" bucket. I'm opening them here as a single umbrella so they can be claimed and worked in parallel instead of buried in the individual PR threads.

1. Stale docstring in TreePredictor.deserialize

src/gluonts/ext/rotbaum/_predictor.py around line 367:

def deserialize(cls, path: Path, **kwargs: Any) -> \"TreePredictor\":
    \"\"\"
    ...
    It loads the predictor class with the serialized arguments. It then
    loads the trained model list by reading the pickle file.
    \"\"\"

After #3176, the method reads model_list.json, not predictor.pkl. The docstring should match. (#3294 touches this line as part of its fallback change; if that PR lands first this item is resolved.)

2. Regression coverage the recent PRs didn't add

Each of these PRs changed an observable behaviour but didn't pin it in a test; the list is short enough that each one is a small, self-contained test file:

Not asking for anything cosmetic

Each bullet above was surfaced while validating a substantive behaviour change; none are style nits. Happy to send the docstring fix now and the test additions as separate small PRs if maintainers would like them split up by topic. Flagging good first issue since the scope per bullet is small and the relevant PR already explains the intended behaviour.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions