[ZEPPELIN-6557] Add history-based inline completion to the new UI editor - #5339
Open
voidmatcha wants to merge 2 commits into
Open
[ZEPPELIN-6557] Add history-based inline completion to the new UI editor#5339voidmatcha wants to merge 2 commits into
voidmatcha wants to merge 2 commits into
Conversation
voidmatcha
force-pushed
the
monaco-upgrade-spike
branch
from
July 28, 2026 13:08
ab69238 to
6ebfb7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Adds ghost-text inline completion to the new UI notebook editor. It is the first, LLM-free, opt-in step of ZEPPELIN-6329 (AI autocomplete).
InlineCompletionServiceregisters a Monaco inline-completions provider for python/scala: when a line elsewhere in the note starts with the current line's text before the cursor, it offers the remainder as ghost text (the current cell first, then other paragraphs of the same language). There is no server call and no API key — everything is in-browser, in-memory string matching, in the spirit of fish/JupyterLab history completion.The feature is off by default and only active with
?aiInlineComplete=true; with the flag off there is no behaviour change and no provider is registered.This requires bumping Monaco 0.31.1 → 0.52.2 (and
monaco-editor-webpack-plugin7.0.1 → 7.1.1) for the stabilised inline-completion API. The only source compile change iseditor.getAction()becoming nullable. Monaco 0.55/0.56 currently break the webpack plugin (unresolved newcontribmodules), so 0.52.x is the upper bound.The
?aiInlineComplete=trueflag is an experimental gate for this purely-local tier. When the server-backed LLM tier lands (follow-up sub-task), inline completion will be promoted to a proper, persisted user setting.What type of PR is it?
Improvement
Todos
npm cilock verifiedInlineCompletionService(opt-in, history-based ghost text)What is the Jira issue?
ZEPPELIN-6557 (sub-task of ZEPPELIN-6329)
How should this be tested?
cd zeppelin-web-angular && npm run build && npm run lintng serve, log in, open a note with a python paragraph (append?aiInlineComplete=trueto the URL)users = spark.read.parquet("/data/users"); in another, start typingusers = spark.read.— the remainder appears as grey ghost text; press Tab to acceptMonaco 0.52.2 changed the find-widget DOM (
.button.next/title→.codicon-find-next-match/aria-label), so the selectors ine2e/models/editor-search-page.tswere updated accordingly. Tab only accepts a suggestion while one is visible; otherwise it indents normally (built-in Monaco behaviour, not overridden).Screenshots (if appropriate)
real-typing-demo.mp4
Questions: