feat(topic): add support for retrieving schema compatibility strategy with options#1469
Merged
freeznet merged 1 commit intoMar 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an API option to retrieve the non-applied (topic-level) schema compatibility strategy, while keeping the existing getters returning the applied (effective) strategy.
Changes:
- Extended the
Topicsadmin API with new methods that accept anappliedflag for schema compatibility strategy retrieval. - Updated the existing
GetSchemaCompatibilityStrategy*methods to preserve current behavior by defaulting toapplied=true. - Expanded topic admin tests to validate applied vs non-applied behavior and added a unit test for response parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pulsaradmin/pkg/admin/topic.go | Adds new schema compatibility strategy getters with an applied flag and parses raw JSON-string responses. |
| pulsaradmin/pkg/admin/topic_test.go | Adds coverage for applied vs non-applied retrieval and tests the new parsing helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 tasks
crossoverJie
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
The current topic schema compatibility getter always returns the applied policy, which hides whether the value is explicitly configured on the topic or inherited from namespace or broker defaults. This change adds an explicit applied option so callers can request
applied=falseand retrieve the actual topic-level user configuration without breaking the existing default behavior.Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation