Skip to content

fix(utils): add JSON tag for UpdateAuthData in UpdateOptions#1450

Merged
nodece merged 3 commits into
apache:masterfrom
freeznet:freeznet/fix-UpdateAuthData-json-tag
Dec 15, 2025
Merged

fix(utils): add JSON tag for UpdateAuthData in UpdateOptions#1450
nodece merged 3 commits into
apache:masterfrom
freeznet:freeznet/fix-UpdateAuthData-json-tag

Conversation

@freeznet

Copy link
Copy Markdown
Contributor

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Current impl fails to marshaling the UpdateAuthData to https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/java/org/apache/pulsar/common/functions/UpdateOptionsImpl.java#L36

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes a marshaling issue by adding a JSON struct tag to the UpdateAuthData field in the UpdateOptions struct. The struct is used when updating functions, sources, and sinks via the Pulsar Admin API, and the JSON tag ensures proper serialization to match the Java implementation's field name updateAuthData.

  • Added json:"updateAuthData" tag to the UpdateAuthData field in UpdateOptions struct
  • Added comprehensive test coverage for both JSON marshaling and unmarshaling of UpdateOptions

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pulsaradmin/pkg/utils/update_options.go Added JSON struct tag to enable proper marshaling of UpdateAuthData field
pulsaradmin/pkg/utils/update_options_test.go Added new test file with tests for JSON marshaling and unmarshaling of UpdateOptions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pulsaradmin/pkg/utils/update_options.go Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@crossoverJie crossoverJie added this to the v0.19.0 milestone Dec 12, 2025
@nodece nodece merged commit 9785c01 into apache:master Dec 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants