Bump the minimum Go version to 1.22#1300
Merged
BewareMyPower merged 3 commits intoOct 26, 2024
Merged
Conversation
BewareMyPower
requested review from
RobertIndie,
hezhangjian,
nodece,
shibd and
tisonkun
BewareMyPower
force-pushed
the
bewaremypower/go-1.22
branch
from
38cb2f2 to
e1cf772
Compare
tisonkun
approved these changes
Oct 25, 2024
Contributor
Author
|
There seems to be something wrong with the golangci-run action. Let me take a look |
nodece
approved these changes
Oct 25, 2024
Contributor
Author
|
Though I originally planned to upgrade the golangci-lint in another PR, it looks like golangci-lint 1.51.2 is incompatible with Go 1.22. Hence I just upgraded and fixed lint errors in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Go 1.23 was released at 2024-08-13, which means Go 1.21 won't be supported anymore.
Modifications