[Fix] Fix the key-based batch can't guarantee the ordering when flushing#1252
Merged
Merged
Conversation
BewareMyPower
approved these changes
Jul 19, 2024
RobertIndie
added a commit
that referenced
this pull request
Jul 24, 2024
…ing (#1252) ### Motivation When using key-based producing, the key-based batcher cannot guarantee the sequence ID order when flushing messages. This leads to frequent disconnections between the client and the broker, resulting in poor performance. Here is the related log: ``` time="2024-07-19T03:38:07Z" level=warning msg="Received send error from server: [PersistenceError] : [Cannot determine whether the message is a duplicate at this time]" time="2024-07-19T03:38:07Z" level=warning msg="Connection was closed" cnx="xxx" producerID=1 producer_name=xxx topic="xxx" time="2024-07-19T03:38:07Z" level=warning msg="Failed to write on connection" error="use of closed network connection" local_addr="xxx" remote_addr="xxx" ``` The broker receives unordered messages and returns a SendError to the client. This causes the client to reconnect to the broker. ### Modifications - Refactor the BatchBuilder interface. - Sort batches before flushing in the key-based batcher builder. (cherry picked from commit e2fd4c9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When using key-based producing, the key-based batcher cannot guarantee the sequence ID order when flushing messages. This leads to frequent disconnections between the client and the broker, resulting in poor performance.
Here is the related log:
The broker receives unordered messages and returns a SendError to the client. This causes the client to reconnect to the broker.
Modifications
Verifying this change
This change added tests
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation