Skip to content

[Issue 1223] Support ZeroQueueConsumer#1225

Merged
RobertIndie merged 7 commits into
apache:masterfrom
crossoverJie:fix-issue-1223
Jun 26, 2024
Merged

[Issue 1223] Support ZeroQueueConsumer#1225
RobertIndie merged 7 commits into
apache:masterfrom
crossoverJie:fix-issue-1223

Conversation

@crossoverJie

Copy link
Copy Markdown
Member

Fixes #1223

Motivation

Support ZeroQueueConsumer, refer to Java ZeroQueueConsumerImpl

Modifications

  • The consumer add a new optional parameter EnableZeroQueueConsumer
  • Add a new zeroQueueConsumer

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes)
  • The schema: (no)
  • The default values of configurations: (yes)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (GoDocs)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@crossoverJie

Copy link
Copy Markdown
Member Author

@RobertIndie PTAL, thanks.

Comment thread pulsar/consumer_impl.go
Comment thread pulsar/consumer_zero_queue.go Outdated
Comment thread pulsar/consumer_zero_queue.go Outdated
Comment thread pulsar/consumer_zero_queue_test.go
@crossoverJie crossoverJie requested a review from RobertIndie June 14, 2024 01:56
@crossoverJie crossoverJie self-assigned this Jun 24, 2024
@RobertIndie RobertIndie merged commit aa090be into apache:master Jun 26, 2024
@RobertIndie RobertIndie added this to the v0.13.0 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question]Zero value of ReceiverQueueSize

2 participants