Skip to content

[Bug Fix]Fix available permits in MessageReceived#1181

Merged
RobertIndie merged 4 commits into
apache:masterfrom
panszobe:fix_availablePermits
Feb 23, 2024
Merged

[Bug Fix]Fix available permits in MessageReceived#1181
RobertIndie merged 4 commits into
apache:masterfrom
panszobe:fix_availablePermits

Conversation

@panszobe

@panszobe panszobe commented Feb 23, 2024

Copy link
Copy Markdown
Contributor

Fixes #1180

Motivation

In the MessageReceived, the number of skipped messages should be increased to available permits to avoid skipped permits leading flow request not be sent.

@lhotari

lhotari commented Feb 23, 2024

Copy link
Copy Markdown
Member

@panszobe Good catch! Thanks for the contribution.

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari requested a review from tisonkun February 23, 2024 12:54
@RobertIndie RobertIndie added this to the v0.13.0 milestone Feb 23, 2024
@RobertIndie RobertIndie merged commit 5d25827 into apache:master Feb 23, 2024
RobertIndie pushed a commit that referenced this pull request Feb 29, 2024
Fixes #1180

### Motivation
In the `MessageReceived`, the number of skipped messages should be increased to available permits to avoid skipped permits leading flow request not be sent.
---------

Co-authored-by: panjinjun <1619-panjinjun@users.noreply.git.sysop.bigo.sg>
(cherry picked from commit 5d25827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consumers can't keep on consuming messages while Pulsar Broker restarting even the consumer has been reconnected to the broker

3 participants