Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[master] Remove .clang-format entry from .gitignore file - #20664

Merged
szha merged 1 commit into
apache:masterfrom
mozga-intel:mozga-intel/clang_format_file_delete_from_git_ignore
Oct 19, 2021
Merged

[master] Remove .clang-format entry from .gitignore file#20664
szha merged 1 commit into
apache:masterfrom
mozga-intel:mozga-intel/clang_format_file_delete_from_git_ignore

Conversation

@mozga-intel

Copy link
Copy Markdown
Contributor

Description

To keep the same version of the file locally ~ the entry can be removed from .gitignore' file

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot

Copy link
Copy Markdown

Hey @mozga-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, sanity, unix-cpu, website, unix-gpu, centos-gpu, windows-gpu, edge, miscellaneous, windows-cpu, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mozga-intel mozga-intel changed the title [master] A clang-format file can be removed from .gitignore file [master] A clang-format entry can be removed from .gitignore file Oct 13, 2021
@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Oct 13, 2021
@mozga-intel mozga-intel changed the title [master] A clang-format entry can be removed from .gitignore file [master] Remove .clang-format entry from .gitignore file Oct 13, 2021
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 13, 2021
@szha
szha merged commit 9e97732 into apache:master Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants