Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Ban "plain" Guice
We use the one with "classes" classifier. Clean up
dependencies as well as we had both, plus we had
popping up via some test deps as well.

Ban the "plain" JAR as well, to make sure we have
only the proper ASM-less one here.
  • Loading branch information
cstamas committed Jun 11, 2025
commit ef588b1e0aef0b1d4559acfd0f751b2528b43a19
1 change: 1 addition & 0 deletions compat/maven-compat/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ under the License.
<dependency>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<classifier>classes</classifier>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
1 change: 1 addition & 0 deletions compat/maven-embedder/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ under the License.
<dependency>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<classifier>classes</classifier>
<scope>provided</scope>
</dependency>

Expand Down
1 change: 1 addition & 0 deletions compat/maven-resolver-provider/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ under the License.
<dependency>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<classifier>classes</classifier>
<scope>provided</scope>
</dependency>

Expand Down
1 change: 1 addition & 0 deletions impl/maven-cli/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ under the License.
<dependency>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<classifier>classes</classifier>
<scope>provided</scope>
</dependency>

Expand Down
1 change: 1 addition & 0 deletions impl/maven-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ under the License.
<dependency>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<classifier>classes</classifier>
<scope>provided</scope>
</dependency>

Expand Down
1 change: 1 addition & 0 deletions impl/maven-testing/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ under the License.
<dependency>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<classifier>classes</classifier>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
17 changes: 12 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -351,11 +351,6 @@ under the License.
<version>${guiceVersion}</version>
<classifier>classes</classifier>
</dependency>
<dependency>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
<version>${guiceVersion}</version>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
Expand Down Expand Up @@ -647,6 +642,12 @@ under the License.
<artifactId>plexus-testing</artifactId>
<version>${plexusTestingVersion}</version>
<scope>test</scope>
<exclusions>
<exclusion>
<groupId>com.google.inject</groupId>
<artifactId>guice</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.junit</groupId>
Expand Down Expand Up @@ -885,9 +886,15 @@ under the License.</licenseText>
<rules>
<bannedDependencies>
<excludes>
<!-- we use com.google.inject:classes:guice -->
<exclude>com.google.inject:guice:*</exclude>
<!-- we use org.codehaus.plexus:* -->
<exclude>org.sonatype.plexus:plexus-sec-dispatcher</exclude>
<exclude>org.sonatype.plexus:plexus-cipher</exclude>
</excludes>
<includes>
<include>com.google.inject:guice:*:jar:*:classes</include>
</includes>
<message>ensure no more org.sonatype.plexus:plexus-cipher and org.sonatype.plexus:plexus-sec-dispatcher.</message>
</bannedDependencies>
</rules>
Expand Down
Loading