feat: Support TIMELINE_SERVER_BASED markers for flink writer#14202
Merged
Conversation
danny0405
reviewed
Nov 4, 2025
danny0405
reviewed
Nov 4, 2025
cshuo
force-pushed
the
fix_flink_timeline_based_marker
branch
from
4ebf77f to
4b63a0c
Compare
github-actions
Bot
added
size:M
cshuo
force-pushed
the
fix_flink_timeline_based_marker
branch
2 times, most recently
from
8b13e6d to
cd2df14
Compare
github-actions
Bot
added
size:S
danny0405
approved these changes
Nov 5, 2025
cshuo
force-pushed
the
fix_flink_timeline_based_marker
branch
from
cd2df14 to
d7e5c4c
Compare
Contributor
|
The failure is irelevent: TestFiltersInFileGroupReader.testFiltersInFileFormat |
danny0405
reviewed
Nov 7, 2025
|
|
||
| @ParameterizedTest | ||
| @EnumSource(MarkerType.class) | ||
| public void testMarkType(MarkerType markerType) throws Exception { |
Contributor
There was a problem hiding this comment.
can you also add a test in TestFlinkWriteClients to ensure that the default marker type for Flink is still DIRECT.
github-actions
Bot
added
size:M
yihua
force-pushed
the
fix_flink_timeline_based_marker
branch
from
673ff88 to
f74f0f3
Compare
nsivabalan
pushed a commit
that referenced
this pull request
Dec 12, 2025
nsivabalan
pushed a commit
to nsivabalan/hudi
that referenced
this pull request
Dec 12, 2025
nsivabalan
pushed a commit
that referenced
this pull request
Dec 12, 2025
Bumping release candidate number 2
3 tasks
linliu-code
pushed a commit
to linliu-code/hudi
that referenced
this pull request
Jan 22, 2026
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
Fix #14201
Currently flink writer do not support TIMELINE_SERVER_BASED mark type, we should support it to optimize the marker-related latency for fs with non-trivial I/O latency, such as S3.
Summary and Changelog
Support TIMELINE_SERVER_BASED markers for flink writer
Impact
Optimize the marker-related latency for fs with non-trivial I/O latency, such as S3.
Risk Level
low
Documentation Update
Contributor's checklist