improve performance of filter bundle building by reusing stuff when possible - #18488
Merged
gianm merged 2 commits intoSep 5, 2025
Merged
Conversation
…olean filters when possible
capistrant
approved these changes
Sep 5, 2025
capistrant
left a comment
capistrant
left a comment
Contributor
There was a problem hiding this comment.
This is cool, thanks for submitting! I was gonna ask about tests for the new method but I guess it is implicitly under test from the existing FilterBundle tests. 👍
gianm
approved these changes
Sep 5, 2025
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…ossible (apache#18488) * improve performance of filter bundle building by reusing stuff for boolean filters when possible * slightly less garbage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves
FilterBundle.Builderperformance by adding a method toBooleanFilterto allow building aBitmapColumnIndexusingFilterBundle.Builderof the child filters instead of directly from the child filters, which allow re-use of things such asBitmapColumnIndexwhich are also computed by the builder.