Remove usages of DruidLeaderClient from extensions - #18297
Merged
Conversation
uds5501
reviewed
Jul 21, 2025
| .useLatchableEmitter() | ||
| .addExtension(CatalogClientModule.class) | ||
| .addExtension(CatalogCoordinatorModule.class) | ||
| .addExtension(AWSModule.class) |
Contributor
There was a problem hiding this comment.
Q: Why do we need the AWS module?
Contributor
Author
There was a problem hiding this comment.
Thanks! Yeah, this is not needed here. Must have been left over from when I was debugging this test.
Contributor
|
The changes LGTM :D |
cryptoe
approved these changes
Jul 23, 2025
cryptoe
left a comment
cryptoe
left a comment
Contributor
There was a problem hiding this comment.
Changes LGTM. Thanks for the patch and sun-setting DruidLeaderClient.
Contributor
Author
10 tasks
kfaraz
added a commit
that referenced
this pull request
Jul 25, 2025
…18326) #18297 added a CoordinatorServiceClient as a replacement for DruidLeaderClient to druid-basic-security extension. This client is a wrapper over ServiceClient for querying non-core APIs exposed by the Coordinator. (For core APIs, CoordinatorClient should be used). This patch moves that class to druid-server so that it may be used by other extensions too if needed.
riovic918data
added a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
Description: This is a follow up to the work done by @uds5501 in apache#18142 , apache#18192 and apache#18195 to replace usages of `DruidLeaderClient` with a `ServiceClient`-based implementation. Changes: - Remove usages of `DruidLeaderClient` in extensions `druid-basic-security` and `druid-catalog` - Use `ServiceClient` to make HTTP calls instead - Remove classes `DruidLeaderClient`, `CoordinatorDiscoveryModule` - Add embedded test `CatalogCompactionTest`
riovic918data
added a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…pache#18326) apache#18297 added a CoordinatorServiceClient as a replacement for DruidLeaderClient to druid-basic-security extension. This client is a wrapper over ServiceClient for querying non-core APIs exposed by the Coordinator. (For core APIs, CoordinatorClient should be used). This patch moves that class to druid-server so that it may be used by other extensions too if needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to the work done by @uds5501 in #18142 , #18192 and #18195
to replace usages of
DruidLeaderClientwith aServiceClient-based implementation.Changes
DruidLeaderClientin extensionsdruid-basic-securityanddruid-catalogServiceClientto make HTTP calls insteadDruidLeaderClient,CoordinatorDiscoveryModuleCatalogCompactionTestThis PR has: