Web console: support SET syntax in queries - #17966
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
clintropolis
approved these changes
May 1, 2025
Comment on lines
+239
to
+242
| // Semicolon (;) at the end. https://bit.ly/1n1yfkJ | ||
| // ex: SELECT 1; | ||
| // ex: Received an unexpected token [;] (line [1], column [9]), acceptable options: | ||
| // Missing (;) after SET statement | ||
| // ex: SET sqlTimeZone = 'America/Los_Angeles' SELECT * FROM "kttm_simple" | ||
| // ex: Received an unexpected token [SELECT] (line [1], column [41]), acceptable options: [<EOF>, <QUOTED_STRING>, ";", "UESCAPE"] | ||
| // /Received an unexpected token \[;] \(line \[(\d+)], column \[(\d+)]\),/i |
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
* fix explain and semicolon suggestion * move Edit context * update for CodeQL feedback * removed left over old comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the web console follow up to #17894 adds support for parsing and manipulating the new SET syntax. Changes the handling for the now allowed trailing semicolon.