Fix deterministic server selection in balancer by adding tie-breaking logic - #17764
Merged
gianm merged 1 commit intoApr 2, 2025
Merged
Conversation
…ases Previously, when multiple servers had the same number of active connections, the balancer would always select the same server deterministically. This led to uneven distribution in certain cases. This commit introduces a simple tie-breaking mechanism to ensure a more balanced distribution.
cmick
force-pushed
the
feature/improve-connectioncount-query-balancing
branch
from
February 28, 2025 13:11
2ff15b7 to
0efd663
Compare
cryptoe
requested changes
Mar 25, 2025
Contributor
|
I'll merge this, it looks ok to me. @cmick thank you for your contribution! |
Contributor
Author
|
Thanks, @gianm ! Appreciate the quick review and merge. Glad to have contributed! |
Contributor
|
This looks good 🚀 |
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…ases (apache#17764) Previously, when multiple servers had the same number of active connections, the balancer would always select the same server deterministically. This led to uneven distribution in certain cases. This commit introduces a simple tie-breaking mechanism to ensure a more balanced distribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current connection count query balancer (when
druid.broker.balancer.type=connectionCount) behavior in Apache Druid has a deterministic server selection mechanism when multiple servers have the same number of active connections. This results in uneven query distribution, particularly in the following cases:Likely the same problem is described in an old issue here: #3777
Proposed Fix
This PR introduces a simple tie-breaking mechanism in the balancer to prevent deterministic selection when multiple servers have the same connection count. This will improve overall load balancing by:
Impact:
The fix only impacts clusters with
druid.broker.balancer.type=connectionCountset (by default it is set torandom):Testing:
Related Issues:
Let me know if any additional details should be included!
Release note
This PR has: