Skip to content

fix(parquet): reject short page writes - #1050

Open
fallintoplace wants to merge 2 commits into
apache:mainfrom
fallintoplace:fix/parquet-page-short-writes
Open

fix(parquet): reject short page writes#1050
fallintoplace wants to merge 2 commits into
apache:mainfrom
fallintoplace:fix/parquet-page-short-writes

Conversation

@fallintoplace

@fallintoplace fallintoplace commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • return io.ErrShortWrite when a direct dictionary or data page body write accepts fewer bytes than requested
  • avoid updating page counters and indexes after an incomplete body write
  • cover both direct page paths with a short-writing sink

Testing

  • go test ./parquet/file

@fallintoplace
fallintoplace requested a review from zeroshade as a code owner July 28, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant