Skip to content

Render k8s yaml for tasks via the Airflow UI - #11815

Merged
kaxil merged 3 commits into
apache:masterfrom
astronomer:render-k8s-yaml
Nov 9, 2020
Merged

Render k8s yaml for tasks via the Airflow UI#11815
kaxil merged 3 commits into
apache:masterfrom
astronomer:render-k8s-yaml

Conversation

@dimberman

@dimberman dimberman commented Oct 24, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This function allows users of the k8s executor to get previews
of their tasks via the Airflow UI before they launch

Screen Shot 2020-11-03 at 8 04 32 AM

Screen Shot 2020-11-03 at 8 04 40 AM

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg Bot added the area:webserver Webserver related Issues label Oct 24, 2020
@dimberman dimberman changed the title Render k8s yaml Render k8s yaml for tasks via the Airflow UI Oct 24, 2020
@dimberman
dimberman requested a review from kaxil October 24, 2020 07:50
@dimberman

dimberman commented Oct 24, 2020

Copy link
Copy Markdown
Contributor Author

cc: @ryanahamilton I still have a small bug on getting the button on the DAG view to work (also would love to merge this with those assets you built :) )

@github-actions

github-actions Bot commented Oct 24, 2020

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions

github-actions Bot commented Oct 24, 2020

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

ryanahamilton
ryanahamilton reviewed Oct 26, 2020
View reviewed changes

@ryanahamilton ryanahamilton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimberman I added a few questions/suggestions. We'll want to make the navigation links visible conditional on the executor. I can work on that when I add the other visual updates.

Comment thread airflow/www/views.py Outdated
Comment thread airflow/www/views.py Outdated
ryanahamilton
ryanahamilton reviewed Oct 26, 2020
View reviewed changes
Comment thread airflow/www/templates/airflow/dag.html Outdated
@dimberman
dimberman force-pushed the render-k8s-yaml branch 4 times, most recently from fd71198 to cbf6ace Compare October 28, 2020 15:13
@ryanahamilton
ryanahamilton force-pushed the render-k8s-yaml branch 7 times, most recently from 7a5a5a5 to b7a05da Compare October 30, 2020 13:17
ryanahamilton
ryanahamilton reviewed Oct 30, 2020
View reviewed changes
Comment thread airflow/models/taskinstance.py Outdated
@apache apache deleted a comment from github-actions Bot Oct 30, 2020
@apache apache deleted a comment from github-actions Bot Oct 30, 2020
@apache apache deleted a comment from github-actions Bot Oct 30, 2020
@apache apache deleted a comment from github-actions Bot Oct 30, 2020
@apache apache deleted a comment from github-actions Bot Oct 30, 2020
@apache apache deleted a comment from github-actions Bot Oct 30, 2020
kaxil
kaxil reviewed Nov 9, 2020
View reviewed changes
Comment thread airflow/models/renderedtifields.py Outdated
@kaxil
kaxil requested review from ashb, mik-laj and turbaszek November 9, 2020 14:45
@github-actions

github-actions Bot commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

ashb
ashb reviewed Nov 9, 2020
View reviewed changes
Comment thread airflow/models/renderedtifields.py Outdated
ashb
ashb reviewed Nov 9, 2020
View reviewed changes
Comment thread airflow/www/views.py Outdated
ashb
ashb reviewed Nov 9, 2020
View reviewed changes
Comment thread airflow/www/views.py Outdated
@potiuk

potiuk commented Nov 9, 2020

Copy link
Copy Markdown
Member

@kaxil - you might want to rebase and force-push again - the #12205 merged should help with the backport packages failing.

dimberman and others added 2 commits November 9, 2020 16:59
@dimberman @ryanahamilton @kaxil
Render k8s yaml for tasks
6361baa 
This function allows users of the k8s executor to get previews
of their tasks via the aiflow UI before they launch

Co-authored-by: Ryan Hamilton <ryan@ryanahamilton.com>
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
@kaxil
fixup! Render k8s yaml for tasks
e96c57e
@kaxil

kaxil commented Nov 9, 2020

Copy link
Copy Markdown
Member

@kaxil - you might want to rebase and force-push again - the #12205 merged should help with the backport packages failing.

Done, thanks

@potiuk

potiuk commented Nov 9, 2020

Copy link
Copy Markdown
Member

Sorry. Seems some unfetched commits got into our way

@kaxil

kaxil commented Nov 9, 2020

Copy link
Copy Markdown
Member

Np at all, all good :)

@ashb
ashb dismissed turbaszek’s stale review November 9, 2020 17:12

Requested changes have been made

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Nov 9, 2020
@github-actions

github-actions Bot commented Nov 9, 2020

Copy link
Copy Markdown
Contributor

The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!

@kaxil
kaxil merged commit 90a1478 into apache:master Nov 9, 2020
@kaxil
kaxil deleted the render-k8s-yaml branch November 9, 2020 19:55
@ryanahamilton ryanahamilton mentioned this pull request Nov 10, 2020
Merged
kaxil pushed a commit that referenced this pull request Nov 10, 2020
@ryanahamilton
Fix: Conditionally update button URL only when it is present (#12268)
938c512 
Resolves #12254

A bug introduced in #11815. The function that updates the button URLs was failing when trying to update the "K8s Pod Spec" which is conditionally displayed (if k8s_or_k8scelery_executor). This fix adds a check to confirm the button exists before attempting.
@mik-laj mik-laj mentioned this pull request Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanahamilton ryanahamilton ryanahamilton left review comments
@potiuk potiuk potiuk left review comments
@kaxil kaxil kaxil left review comments
@ashb ashb ashb approved these changes
@mik-laj mik-laj Awaiting requested review from mik-laj
@turbaszek turbaszek Awaiting requested review from turbaszek

Assignees

No one assigned

Labels

area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Milestone

Airflow 2.0.0-beta1

Development

Successfully merging this pull request may close these issues.

7 participants

@dimberman @kaxil @potiuk @ryanahamilton @ashb @turbaszek @mik-laj