Skip to content

Enable Black on Providers Packages - #10543

Merged
kaxil merged 17 commits into
apache:masterfrom
astronomer:providers-black
Aug 25, 2020
Merged

Enable Black on Providers Packages#10543
kaxil merged 17 commits into
apache:masterfrom
astronomer:providers-black

Conversation

@kaxil

@kaxil kaxil commented Aug 25, 2020

Copy link
Copy Markdown
Member

This is part of #9550 but only applies Black formatting to providers packages as they are not included in v1-10-test so the problem for cherry-picking them does not arises.

If there are any open PR, they just need to run pre-commit and everything would be taken care off


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg Bot added area:dev-tools provider:amazon AWS/Amazon - related issues labels Aug 25, 2020
@kaxil
kaxil requested review from mik-laj, potiuk and turbaszek August 25, 2020 09:15
@potiuk

potiuk commented Aug 25, 2020

Copy link
Copy Markdown
Member

Great idea to enable black on Providers first!

@turbaszek turbaszek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Should we apply black on tests/providers?

@kaxil

kaxil commented Aug 25, 2020

Copy link
Copy Markdown
Member Author

Awesome! Should we apply black on tests/providers?

Yup already applied

@turbaszek

Copy link
Copy Markdown
Member

Yup already applied

Good! There is too much file to be able to load it all in Github 😄

@turbaszek

Copy link
Copy Markdown
Member

@kaxil

kaxil commented Aug 27, 2020

Copy link
Copy Markdown
Member Author

It is even simpler by adding "black" profile to isort which is in #9550 which applies black to entire airflow repo. Waiting till we are close to 2.0 and then do a big bang so we don't need to cherrypick anymore and can pause the PRs for that time

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 15, 2021
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2021
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 25, 2021
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 9, 2022
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 3, 2022
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 6, 2022
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 9, 2022
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 27, 2022
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 11, 2024
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 16, 2024
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 6, 2024
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 1, 2025
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 21, 2025
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 16, 2025
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 15, 2025
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Feb 20, 2026
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Apr 19, 2026
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 22, 2026
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 22, 2026
Based on apache/airflow#10543 (comment)

GitOrigin-RevId: a0e7c40717758c4c93c3f11b249bbf6773043b45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants