Fix: BaseWalletConnection doesn't pass thru classname prop - #967
Open
asktree wants to merge 1 commit into
Open
Conversation
asktree
commented
May 18, 2024
| import { WalletIcon } from './WalletIcon.js'; | ||
|
|
||
| type Props = React.ComponentProps<typeof Button> & { | ||
| type Props = ButtonProps & { |
Author
There was a problem hiding this comment.
I did this type change because eslint/prop-types was complaining that className was not among the props, ostensibly this is a bug in the rule. I'm not sure this prop-types rule does anything if you're using strict ts anyway.
|
Is this planned to be fixed in a release soon? I see its almost a year old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BaseWalletConnection component is currently overwriting any className prop. I made it not do this. If this is intentional, then className should not be among its props.