Implement options for ZRANGE, ZRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE#78
Closed
brstgt wants to merge 2 commits into
Closed
Implement options for ZRANGE, ZRANGEBYSCORE, ZREVRANGE, ZREVRANGEBYSCORE#78brstgt wants to merge 2 commits into
brstgt wants to merge 2 commits into
Conversation
kelunik
reviewed
Oct 9, 2022
| * @return Promise | ||
| */ | ||
| public function getRange(int $start, int $end): Promise | ||
| public function getRange(int $start, int $end, RangeOptions $options = null): Promise |
Member
There was a problem hiding this comment.
Suggested change
| public function getRange(int $start, int $end, RangeOptions $options = null): Promise | |
| public function getRange(int $start, int $end, ?RangeOptions $options = null): Promise |
kelunik
reviewed
Nov 3, 2022
| return $this->withScores; | ||
| } | ||
|
|
||
| public function withOffset(int $offset, int $count): self |
Member
There was a problem hiding this comment.
Shouldn't this be called withLimit instead?
kelunik
reviewed
Nov 8, 2022
| * @return Promise | ||
| */ | ||
| public function getRangeByScore(float $min, float $max): Promise | ||
| public function getRangeByScore(float $min, float $max, RangeByScoreOptions $options = null): Promise |
Member
There was a problem hiding this comment.
Suggested change
| public function getRangeByScore(float $min, float $max, RangeByScoreOptions $options = null): Promise | |
| public function getRangeByScore(float $min, float $max, ?RangeByScoreOptions $options = null): Promise |
kelunik
reviewed
Nov 8, 2022
| * @return Promise | ||
| */ | ||
| public function getReverseRangeByScore(float $min, float $max): Promise | ||
| public function getReverseRangeByScore(float $min, float $max, RangeByScoreOptions $options = null): Promise |
Member
There was a problem hiding this comment.
Suggested change
| public function getReverseRangeByScore(float $min, float $max, RangeByScoreOptions $options = null): Promise | |
| public function getReverseRangeByScore(float $min, float $max, ?RangeByScoreOptions $options = null): Promise |
Closed
Member
|
Merged in b720d08. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.