Skip to content

Issue 812 - Implement point_partial_derivatives for dim3#831

Merged
icui merged 13 commits into
develfrom
issue-812
May 28, 2025
Merged

Issue 812 - Implement point_partial_derivatives for dim3#831
icui merged 13 commits into
develfrom
issue-812

Conversation

@icui

@icui icui commented May 13, 2025

Copy link
Copy Markdown
Collaborator

Description

  • Re-organize operator location
  • Add 3D specification and instantiation

Issue Number

Closes #812

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@icui

icui commented May 16, 2025

Copy link
Copy Markdown
Collaborator Author

retest this please.

@icui icui requested review from Rohit-Kakodkar and lsawade May 16, 2025 13:27

@lsawade lsawade left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rohit-Kakodkar

Copy link
Copy Markdown
Collaborator

Are you implementing the accessor and cointainer concepts, discussed within #832 , within this PR ? The enum classes for accessors could be part of this PR.

@icui icui merged commit dc9bd73 into devel May 28, 2025
6 checks passed
@lsawade lsawade added the enhancement New feature or request label Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants