Skip to content

Fixes bug related to property assignment at GLL points#673

Merged
lsawade merged 1 commit into
develfrom
issue-672
Mar 25, 2025
Merged

Fixes bug related to property assignment at GLL points#673
lsawade merged 1 commit into
develfrom
issue-672

Conversation

@Rohit-Kakodkar

Copy link
Copy Markdown
Collaborator

Description

  • Updated the properties assignment
  • Updated constructors for assembly and properties

Issue Number

closes #672

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

- [ ] Updated the properties assignment
- [ ] Updated constructors for assembly and properties
@Rohit-Kakodkar Rohit-Kakodkar requested review from icui and lsawade March 24, 2025 15:11

@lsawade lsawade left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy find, @int-ptr-ptr !

@lsawade lsawade merged commit d3a7c03 into devel Mar 25, 2025
@lsawade lsawade added bug Something isn't working fix labels Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants