Convert aniseed dependecy to nfnl#716
Merged
Merged
Conversation
Contributor
Author
|
Sorry, I missed these:
|
Contributor
Author
|
Apologies for the straggler fixes. |
Owner
|
Not a problem! Any contributions are appreciated! |
Olical
reviewed
Oct 17, 2025
| {:buf-suffix ".fnl" | ||
| :comment-prefix "; " | ||
| :form-node? ts.node-surrounded-by-form-pair-chars? | ||
| :comment-node? ts.lisp-comment-node?})) |
Owner
There was a problem hiding this comment.
I've made some changes to this file that are subtle. Overall this change is fine but what I did was:
- Move these exported values out of the default table and into
(set M.buf-suffix ...)lines. This way every time I reload the file the new changes to those keys are exported. This table is only used ONCE when the module is first defined as a default and is mostly there if you want to, say, require another module and augment it. It won't update though if you change it and re-eval because the module is already defined. The "default" default value here is just{}so you don't need to pass anything really, it's for rare special cases. - Added
(local vim _G.vim)which appeases the linter. Kinda silly but not awful. I can't seem to appease the linter any other way but that might be my own Skill Issue. - Moved
stateto be inM.stateand used(set M.state (or M.state ...))to give it a default but keep it stable between reloads.
Contributor
Author
There was a problem hiding this comment.
I saw that pattern in conjure.client.lua.neovim and conjure.client.fennel.nfnl so monkey-see monkey-did. Now I understand why not to. Thanks!
Olical
reviewed
Oct 17, 2025
| [:BufNewFile :BufRead] | ||
| {:group (vim.api.nvim_create_augroup :conjure_school_filetype {:clear true}) | ||
| :pattern :*.fnl | ||
| :command "setlocal filetype=clojure"})) |
Owner
|
Looks good, works good, deletes more lines than it adds, loads less Lua modules. This is great! Thank you, Russ! 😄 |
Contributor
Author
|
Glad to help move things along! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I've got most of the remaining Aniseed dependencies converted to nfnl.
I'm not sure if we can get rid of: