feat(desktop): browse remote backend files (salvage #43434)#44326
Merged
Conversation
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-import |
2 |
First entries
tests/hermes_cli/test_web_server_fs.py:9: [unresolved-import] unresolved-import: Cannot resolve imported module `starlette.testclient`
tests/hermes_cli/test_web_server_fs.py:4: [unresolved-import] unresolved-import: Cannot resolve imported module `pytest`
✅ Fixed issues: none
Unchanged: 5609 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
This was referenced Jun 11, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Salvage of #43434 by @yoniebans onto current main: the Desktop Files panel now routes by connection mode — local keeps Electron filesystem IPC, remote uses authenticated read-only
/api/fs/*backend REST, so remote-backed Desktop sessions can browse and preview backend files instead of resolving paths on the client machine.Fixes #42878.
Changes
hermes_cli/web_server.py: read-only/api/fs/{list,read-text,read-data-url,git-root,default-cwd}endpoints (auth-gated, size-capped, binary sniffing)apps/desktop/src/lib/desktop-fs.ts: routing facade — local IPC vswindow.hermesDesktop.apiSalvage notes
web_server.pyconflict: the managed-files (/api/files) block landed after branch point; resolved keeping main's block plus the PR's/api/fs/*block.use-project-tree.test.tsconflict: kept main's error-placeholder expectations (fix(desktop): Harden local file tree paths #43618) plus the PR's per-connection gitignore cache test.Validation
scripts/run_tests.sh tests/hermes_cli/test_web_server_fs.pynpm run typecheckOriginal PR's shard-5 CI failure was an infra flake (splitter re-invoked pytest on a checkout missing the new test file); all 4617 tests had passed.
Infographic