Plot brain decode#345
Merged
Merged
Conversation
Change default value n_classes=None
# Conflicts: # examples/plot_BrainDecode.py
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
# Conflicts: # examples/plot_BrainDecode2.py # moabb/pipelines/deep_learning_BrainDecode.py
sylvchev
reviewed
Mar 17, 2023
sylvchev
left a comment
sylvchev
left a comment
Member
There was a problem hiding this comment.
I'd favor BraindecodeDatasetLoader instead of LoadMOABBDataset in moabb/pipelines/utils_pytorch.py
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
Co-authored-by: Sylvain Chevallier <sylvain.chevallier@universite-paris-saclay.fr>
sylvchev
approved these changes
Mar 17, 2023
Collaborator
|
I will increase the number of tests to get the green from the codecov |
Member
I think you could add some tests on |
Collaborator
|
I think the codecov report with the patch option may be inaccurate. I've added more tests and covered various parts of the code, but I'm still seeing an 8% reduction. In my opinion, we should disable the patched codecov and only use the project codecov. This issue has also been reported in other repositories, such as kata-containers/tests#508 |
Merged
Member
|
Ok, thanks @bruAristimunha & @carraraig ! |
sylvchev
approved these changes
Mar 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plot BrainDecode example.
This PR is the updated version of the original #340