preload Schirrmsister2017 - Fixes #289#290
Merged
Merged
Conversation
sylvchev
requested changes
May 16, 2022
sylvchev
left a comment
sylvchev
left a comment
Member
There was a problem hiding this comment.
Thank for this PR! Once you update the code, we could merge this.
Member
|
I'm updating some configuration files that causes a CI failure. It is not related with your code, but you will need to update your code branch with the latest develop branch. Feel free to ask if you are not sure how to do it. |
Collaborator
Author
|
I've implemented the comment and updated my branch :) |
sylvchev
approved these changes
May 16, 2022
Member
|
Good, could you update the |
Collaborator
Author
|
Done, sorry forgot about that |
Member
|
Thank you @PierreGtch ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #289