Add option to construct Llama model with Transformer Engine op fuser - #13776
Merged
Conversation
Signed-off-by: Tim Moon <tmoon@nvidia.com>
| "qk_layernorm": config.qk_layernorm, | ||
| "fp8": bool(config.num_moe_experts and (config.fp8 is not None)), | ||
| } | ||
| if getattr(config, "use_transformer_engine_op_fuser", None) is not None: |
Collaborator
There was a problem hiding this comment.
@hemildesai Is backward compatibility necessary here ? Can we just do config.use_transformer_engine_op_fuser
Collaborator
Author
There was a problem hiding this comment.
Alternative implementation that maintains backward compatibility and avoids the None option: https://github.com/timmoon10/NeMo/blob/5094732a45deeb5872ffd72c69ac9ccdb710460e/nemo/collections/llm/gpt/model/base.py#L162-L164
| persist_layer_norm: bool = True | ||
| bias_dropout_fusion: bool = True | ||
| apply_rope_fusion: bool = True | ||
| use_transformer_engine_op_fuser: Optional[bool] = None |
Collaborator
There was a problem hiding this comment.
False seems more simpler ?
gautham-kollu
approved these changes
Jun 3, 2025
chtruong814
approved these changes
Jun 3, 2025
chtruong814
left a comment
chtruong814
left a comment
Collaborator
There was a problem hiding this comment.
Failing test should be resolved after we increased the timeout on main. Going ahead to merge it.
8 tasks
nasretdinovr
pushed a commit
to nasretdinovr/NeMo
that referenced
this pull request
Aug 8, 2025
Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Charlie Truong <chtruong@nvidia.com> Co-authored-by: gautham-kollu <gkollu@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR exposes Megatron-core integration with Transformer Engine's operation fuser. This is an experimental feature.
Collection: NLP
Changelog
Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information