Skip to content

Add option for LoRA with Transformer Engine op fuser - #1324

Merged
cuichenx merged 4 commits into
NVIDIA-NeMo:mainfrom
michal2409:mfutrega/fused_lora
Nov 18, 2025
Merged

Add option for LoRA with Transformer Engine op fuser#1324
cuichenx merged 4 commits into
NVIDIA-NeMo:mainfrom
michal2409:mfutrega/fused_lora

Conversation

@michal2409

Copy link
Copy Markdown
Contributor

What does this PR do ?

Adding feature from NVIDIA-NeMo/Speech#14411

This PR adds a variant of the LoRALinear module using Transformer Engine's operation fuser. It also adds logic in the existing LoRALinear module so that it can call the fused variant. This is an experimental feature.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@copy-pr-bot

copy-pr-bot Bot commented Nov 12, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cuichenx cuichenx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add some tests for the fused path?

@michal2409

Copy link
Copy Markdown
Contributor Author

I've added a test for fused path

@ananthsub

Copy link
Copy Markdown
Contributor

/ok to test 1d0a306

@michal2409

Copy link
Copy Markdown
Contributor Author

/ok to test 02cb88a

@cuichenx
cuichenx merged commit b0c84bc into NVIDIA-NeMo:main Nov 18, 2025
104 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants