Skip to content

Respect HTTP 429 and Retry-After header#628

Merged
NARKOZ merged 1 commit into
NARKOZ:masterfrom
craigmiskell-gitlab:handle-rate-limiting-responses
Oct 11, 2021
Merged

Respect HTTP 429 and Retry-After header#628
NARKOZ merged 1 commit into
NARKOZ:masterfrom
craigmiskell-gitlab:handle-rate-limiting-responses

Conversation

@craigmiskell-gitlab

Copy link
Copy Markdown
Contributor

When a 429 is received, sleep for the length of time indicated by Retry-After, then try again.

Try up to 3 times before giving up, although the count can be configured with :ratelimit_retries if you want more or less

If no Retry-After is sent by the server, defaults to 2 seconds (something is better than nothing). That should only happen with quite old and unsupported versions of GitLab

When a 429 is received, sleep for the length of time indicated by Retry-After, then try again.

Try up to 3 times before giving up, although the count can be configured with :ratelimit_retries if you want more or less

If no Retry-After is sent by the server, defaults to 2 seconds (something is better than nothing). That should only happen with quite old and unsupported versions of GitLab
@NARKOZ NARKOZ merged commit 1e8c635 into NARKOZ:master Oct 11, 2021
@NARKOZ

NARKOZ commented Oct 11, 2021

Copy link
Copy Markdown
Owner

Thank you ❤️

@craigmiskell-gitlab

Copy link
Copy Markdown
Contributor Author

@NARKOZ You're welcome. I'm keen to use this addition; do you have any plans for a new version release anytime soon?

@NARKOZ

NARKOZ commented Oct 12, 2021

Copy link
Copy Markdown
Owner

I plan to release this week.

@craigmiskell-gitlab

Copy link
Copy Markdown
Contributor Author

I plan to release this week.

@NARKOZ It's been a while; any chance we could get that release soon? I would be very grateful.

@NARKOZ

NARKOZ commented Dec 26, 2021

Copy link
Copy Markdown
Owner

@craigmiskell-gitlab I've just released a new version and pushed to Rubygems https://github.com/NARKOZ/gitlab/releases/tag/v4.18.0

Sorry for the wait!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants