feat(chatboxes): allow Generate with AI without required servers#2605
Conversation
A chatbox whose attachments are all optional (or absent) blocked the "Generate with AI" entry point and 400ed both synthetic-session routes with "Chatbox has no required servers". Persona generation now degrades gracefully: the manager comes back connection-less, the captured tool snapshot has zero servers, and the backend grounds personas in the chatbox name instead of a tool inventory. Simulated sessions run toolless, exactly like a real no-opt-in visitor's chat. - ungate the Sessions-tab button and the dialog's Generate action - show a notice in the dialog when generating without tool context - drop the required-servers 400s and the servers .min(1) schemas - regression tests for all-optional and empty server lists Requires the matching mcpjam-backend change (empty tool snapshot + label-only serverAttachment accepted on /session-simulation/generate-personas) to be deployed first. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11e39771af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const generatePersonasSchema = z.object({ | ||
| projectId: z.string().min(1), | ||
| servers: z.array(chatboxServerSchema).min(1), | ||
| servers: z.array(chatboxServerSchema), |
There was a problem hiding this comment.
On the empty/all-optional path enabled here, generate-personas calls createAuthorizedManager with selectedServerIds === []; that helper returns a connection-less manager before calling /web/authorize-batch, while assertBearerToken only checks that a Bearer header exists. This means a request can reach the backend LLM persona-generation call for an arbitrary projectId/chatboxId without the Inspector route first proving the caller can access that chatbox, unlike the previous non-empty-server path. Please add an explicit chatbox/project authorization check before allowing the empty server list.
Useful? React with 👍 / 👎.
Internal previewPreview URL: https://mcp-inspector-pr-2605.up.railway.app |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughThis PR removes server availability gates from persona and session generation. The client button and dialog no longer disable when required servers are absent. The server now accepts empty server lists in both route schemas and eliminates rejection logic in the handlers, allowing personas to be grounded in the chatbox name alone with toolless sessions. Test coverage confirms both all-optional and empty server scenarios work end-to-end. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dosubot
Bot
added
size:M
1 participant
Why
A chatbox whose attachments are all optional (or has none) showed a disabled "Generate with AI" button, and both synthetic-session routes 400ed with "Chatbox has no required servers". If the tool schemas are missing — e.g. someone just forgot to attach a required server — ICP/persona generation should still work with whatever context exists (the chatbox name), not hard-block.
What
ChatboxUsagePanel.tsx— removed the disabled gate (and its dead tooltip — nativetitledoesn't even render on disabled buttons in some browsers).GenerateSessionsDialog.tsx— removed thehasRequiredServersguards on the Generate action; a muted notice explains the degraded mode instead: personas are generated from the chatbox name only, sessions run without tools.server/routes/web/chatbox-sessions.ts— dropped both required-servers 400s and the.min(1)on the servers schemas. No new plumbing needed:createAuthorizedManageralready returns a connection-less manager for zero ids, the snapshot exporter returns an empty snapshot,prepareChatV2tolerates an empty server list, and the simulation runner already guards zero connected servers — so simulated sessions run toolless, exactly like a real no-opt-in visitor's chat.The optional-filtering itself is unchanged: synthetic runs still model the no-opt-in baseline, and the server-side filter still prevents a tampered body from widening the toolset.
Tests
server/routes/web/__tests__/chatbox-sessions.no-required-servers.test.ts(3 tests: all-optional + empty lists on both routes, asserting the empty snapshot and label-only attachment reachgeneratePersonas)server/routes/websuite: 170 passed; dialog + runner tests pass; client typecheck cleanRollout
serverAttachment.resolvedServerNames: [], which the current backend rejects; until the backend ships, the no-required-servers path surfaces a toast error instead of a disabled button (no worse than today, but not yet functional).🤖 Generated with Claude Code
Note
Medium Risk
Changes synthetic session and persona API validation and behavior; full end-to-end success depends on a coordinated backend deploy (mcpjam-backend#511) for empty
resolvedServerNames.Overview
Generate with AI is no longer blocked when a chatbox has only optional servers or none attached. The usage panel always opens the flow; the dialog explains degraded mode and still lets users generate personas.
On the server,
generate-personasandsimulate-sessions/startaccept empty or all-optional server lists instead of returning 400 (Chatbox has no required servers). Zod no longer requires at least one server. With zero required servers, personas are grounded on the chatbox name and synthetic sessions run toolless, matching a no-opt-in visitor. Optional-server filtering for synthetic runs is unchanged.New route tests cover all-optional and empty server payloads for both endpoints.
Reviewed by Cursor Bugbot for commit 11e3977. Bugbot is set up for automated code reviews on this repo. Configure here.