Add norm API for vectors#207
Conversation
|
Thank you very much for the changes.
No, since you are reusing existing implementations, you don't need to add them to LinAlgEx.kt. That file contains methods whose implementations reside in other modules.
Since norm has two implementations, you need to test them in both modules: In the Kotlin implementation: KELinAlgTest.kt |
|
@devcrocod however, unfortunately, i don't have |
|
All tests have passed. I can't say exactly when I will be able to release a new artifact with these changes, as I currently need to completely change the build infrastructure. This is further complicated by issues with the latest versions of Xcode. |
What
added
normAPIs for vector type (i.e.,MultiArray<Float, D1>andMultiArray<Double, D1>).in this implementation, reusing existing
normmethods by using origin vector (mk.zeros(size)).Why
currently, there are
normmethods accepting only matrix (i.e.,MultiArray<Number, D2>).however, NumPy provides
normmethods for vector.sample: https://stackoverflow.com/a/43043160
i think it is better to provide the similar API for usability.
Questions
norm.kt, but should i add them toLinAlgEx.ktfile?