Reject non-power-of-2 alignment in pointerref/pointerset#541
Merged
Conversation
LLVM requires alignment on load/store instructions to be a power of 2 (enforced by the Align class constructor). Passing non-power-of-2 values produces invalid IR that gets silently miscompiled, e.g. causing misaligned vectorized loads that crash on GPU. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## master #541 +/- ##
=======================================
Coverage 87.77% 87.77%
=======================================
Files 45 45
Lines 2723 2725 +2
=======================================
+ Hits 2390 2392 +2
Misses 333 333
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLVM requires alignment on load/store instructions to be a power of 2 (enforced by the Align class constructor). Passing non-power-of-2 values produces invalid IR that gets silently miscompiled, e.g. causing misaligned vectorized loads that crash on GPU.
x-ref JuliaGPU/CUDA.jl#2963