ifw-api: omit password from curl command in check result#10866
Open
Al2Klimov wants to merge 1 commit into
Open
ifw-api: omit password from curl command in check result#10866Al2Klimov wants to merge 1 commit into
Al2Klimov wants to merge 1 commit into
Conversation
Icinga (DB) Web has a special permission to show the check command line. Well-written plugins receive passwords via env vars which don't appear even there. Now ifw-api also hides the password using curl -u USER, not USER:PASS. The new command is still working, it just prompts for the password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icinga (DB) Web has a special permission to show the check command line. Well-written plugins receive passwords via env vars which don't appear even there. Now ifw-api also hides the password using curl -u USER, not USER:PASS. The new command is still working, it just prompts for the password.
(Public PR explicitly requested by @julianbrost.)