chore: soften AssertionError message in live gateway e2e test - #5940
Open
Altamimi-Dev wants to merge 1 commit into
Open
chore: soften AssertionError message in live gateway e2e test#5940Altamimi-Dev wants to merge 1 commit into
Altamimi-Dev wants to merge 1 commit into
Conversation
Closes IBM#5810 The _require_declared_output_schema preflight assert told the reader to 'Rebuild the fast_test_server image and restart docker-compose...' — prescriptive remediation that goes stale. It now reports only the assertion failure (which tool is missing); the surrounding docstring already explains why the guard exists. Signed-off-by: Ahmad Al Tamimi <altamimi.dev@gmail.com>
Altamimi-Dev
requested review from
Lang-Akshay,
brian-hussey,
crivetimihai,
ja8zyjits and
msureshkumar88
as code owners
July 27, 2026 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5810
Summary
The
_require_declared_output_schemapreflight assert intests/live_gateway/mcp/test_mcp_protocol_e2e.pyfailed with prescriptive remediation text (Rebuild the fast_test_server image and restart docker-compose so register_fast_test picks up the new schema fixtures.). That kind of instruction rots — the assertion now reports only the failure itself:The guard's docstring already explains why a stale image or incomplete federation sync causes this, so no diagnostic value is lost. The docstring's "Fails fast with an actionable message" line is updated to match.
Verification
pytest --collect-only: 22 tests).Rebuild the fast_test_serverreferences intests/.tests/live_gatewayis excluded from the defaultmake testrun by design); the change is assertion-message text only, no behavior.