Skip to content

Fixed websocket support in hs.httpserver:start() - #3665

Merged
cmsj merged 2 commits into
masterfrom
issue/3468-fix-websocket-support-in-server-start
Nov 12, 2024
Merged

Fixed websocket support in hs.httpserver:start()#3665
cmsj merged 2 commits into
masterfrom
issue/3468-fix-websocket-support-in-server-start

Conversation

@latenitefilms

Copy link
Copy Markdown
Contributor

@latenitefilms
latenitefilms requested review from asmagill and cmsj August 10, 2024 22:37

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@latenitefilms latenitefilms added the pr-fix Pull Request implementing a bug fix label Aug 10, 2024
Comment thread extensions/httpserver/libhttpserver.m Outdated
@codecov

codecov Bot commented Aug 12, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.70%. Comparing base (ec9a8ea) to head (45eaf01).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3665      +/-   ##
==========================================
+ Coverage   27.65%   27.70%   +0.04%     
==========================================
  Files         191      191              
  Lines       43472    43528      +56     
==========================================
+ Hits        12023    12059      +36     
- Misses      31449    31469      +20     

@cmsj
cmsj merged commit fa58fd4 into master Nov 12, 2024
@cmsj
cmsj deleted the issue/3468-fix-websocket-support-in-server-start branch November 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-fix Pull Request implementing a bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why is an HTTP callback required if I only want a WebSocket server in hs.httpserver?

2 participants