Skip to content

Tooling upgrade - #1627

Merged
DreadKnight merged 11 commits into
FreezingMoon:masterfrom
RobinVdBroeck:tooling-upgrade
Apr 3, 2020
Merged

Tooling upgrade#1627
DreadKnight merged 11 commits into
FreezingMoon:masterfrom
RobinVdBroeck:tooling-upgrade

Conversation

@RobinVdBroeck

@RobinVdBroeck RobinVdBroeck commented Mar 31, 2020

Copy link
Copy Markdown
Contributor
  • Updated dependencies
  • We use prettier 2.0 now
  • Added babel as a preprocessor
  • Remove interface/, instead add the logic to the index.html template
  • Optimized asset loader (I clearly did not understand async / await for 100% back then :P)

@gitpod-io

gitpod-io Bot commented Mar 31, 2020

Copy link
Copy Markdown

@DreadKnight

Copy link
Copy Markdown
Member

Very nice initiative! Will have to look into the analytics stuff again soon; seems neither code really works while looking in the GA dashboard, only the website GA code registers the visitors somehow, even when the game is embedded in various arcade websites. This is so confusing, sigh 😕

Anyway, regarding the last patch, the index.html file is huge and needs to become a template only, hence why stripping things away from it. There's an open issue #1111 just for that kind of stuff.

@DreadKnight

Copy link
Copy Markdown
Member

@RobinVdBroeck Latest build fails because you changed index extension...

@gitpod-io gitpod-io Bot removed the gitpod label Apr 3, 2020
@RobinVdBroeck

Copy link
Copy Markdown
Contributor Author

@DreadKnight It's working in Gitpod now

@DreadKnight
DreadKnight merged commit 49a0bc4 into FreezingMoon:master Apr 3, 2020
@DreadKnight DreadKnight added the pipeline Affects how the project is being developed label Apr 3, 2020
@RobinVdBroeck
RobinVdBroeck deleted the tooling-upgrade branch April 4, 2020 13:59
@DreadKnight

DreadKnight commented Apr 5, 2020

Copy link
Copy Markdown
Member

@RobinVdBroeck Had to revert all these as they crash Heroku even though everything worked nicely on Gitpod and currently the beta version of the game is displayed first thing on the website atm...
Please make more concise individual PRs so I can test/merge 1 by 1 or I could grant you access to Heroku or you could set up an account on your own and test out using the autodeploy feature...
Been trying to use Google Cloud but it's super complicated in comparison to Heroku, so no luck yet.
I wonder if I should just host things by dropping the stuff inside the deploy folder in GitHub pages,
but that's a tad tricky as well as the deploy folder is ignored otherwise it would duplicate all assets.
And if using a different repo altogether, it would avoid continuous integration for the beta version.

@DreadKnight

DreadKnight commented Apr 5, 2020

Copy link
Copy Markdown
Member

@RobinVdBroeck I've opened up #1629, #1630 and #1631 to address these issues separately.

CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pipeline Affects how the project is being developed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants