Fix hover on touch devices - #1526
Merged
DreadKnight merged 2 commits intoMay 15, 2019
Merged
Conversation
* change implementation of hovering button from CSS hover to hover class * add new property to Button class constructor which shows is shortcut needed * add default behaviour for buttons with shortcuts
* add `touchstart` and `touchend` function; * if player touch button and after it move finger more than 50px `click` event doesn't happen
Member
|
@TheSeally Great job, this really makes the difference! |
Contributor
Author
|
Thank you for the opportunity to participate in opensource project. I'm glad to help your project. |
Member
|
Cool, if you can manage that issue as well, awesome! Otherwise there are plenty of other open issues that I greatly struggle with as a crappy coder that I am :D |
CyberBishop
pushed a commit
to CyberBishop/AncientBeast
that referenced
this pull request
Apr 20, 2023
…vices UI tooltips touch events, fixes FreezingMoon#1506
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1506
touchstartandtouchendfunction;clickevent doesn't happen