lint should check all relevant js files

[tristanmkernan]

issue #1422

this PR adds the js files in the src/ directory (subdirectories were already included previously) to the lint check and resolves the relevant errors.

once again some eslint config changes were required because i'm unable to fix them at the present time:

• no-eval: eval is used at one point in the code
• no-new involves side effects and new - this is used for Drops

[ktiedt]

The evals should be simple replaces... just remove the eval() they appear to be just basic operations?

[ktiedt]

Can you be more specific on the new one? I dont see drops being created without new Drop(...) which I believe that pertains to?

[tristanmkernan]

The evals should be simple replaces... just remove the eval() they appear to be just basic operations?

I don't know, I don't want to touch that code right now.

Can you be more specific on the new one? I dont see drops being created without new Drop(...) which I believe that pertains to?

right, new Drop(..) is used for side effects instead of for creating an object. the linter rightly calls it out as bad code

[ktiedt]

Ahh because Drop() is assigning itself to the hex instead of storing the new Drop() value... Ugh.