Skip to content

NaN pickup drop score - #1371

Merged
DreadKnight merged 1 commit into
FreezingMoon:masterfrom
tristanmkernan:issue/1236
Jun 22, 2018
Merged

NaN pickup drop score#1371
DreadKnight merged 1 commit into
FreezingMoon:masterfrom
tristanmkernan:issue/1236

Conversation

@tristanmkernan

Copy link
Copy Markdown
Collaborator

issue #1236

in investigating this issue, i noticed that the drops picked score was NaN in the result screen. this is because the property pickupDrop was never initialized, resulting in undefined + 50 and NaN

that particular scenario can be shown in this gamelog:

"AB-0.3:eyJjb25maWciOnsicGxheWVyTW9kZSI6MiwiY3JlYUxpbWl0TmJyIjozLCJ1bml0RHJvcHMiOjEsImFiaWxpdHlVcGdyYWRlcyI6MywicGxhc21hX2Ftb3VudCI6MzAsInR1cm5UaW1lUG9vbCI6LTEsInRpbWVQb29sIjotNjAsImJhY2tncm91bmRfaW1hZ2UiOiJEYXJrIEZvcmVzdCJ9LCJsb2ciOlt7ImFjdGlvbiI6ImFiaWxpdHkiLCJ0YXJnZXQiOnsidHlwZSI6ImhleCIsIngiOjQsInkiOjR9LCJpZCI6MywiYXJncyI6eyIxIjp7ImNyZWF0dXJlIjoiUDciLCJjb3N0IjoxMH19fSx7ImFjdGlvbiI6InNraXAifSx7ImFjdGlvbiI6Im1vdmUiLCJ0YXJnZXQiOnsieCI6MTIsInkiOjR9fSx7ImFjdGlvbiI6InNraXAifSx7ImFjdGlvbiI6Im1vdmUiLCJ0YXJnZXQiOnsieCI6NiwieSI6NH19LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiaGV4IiwieCI6MTEsInkiOjR9LCJpZCI6MiwiYXJncyI6e319LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiYXJyYXkiLCJhcnJheSI6W3sieCI6MTIsInkiOjR9XX0sImlkIjoxLCJhcmdzIjp7IjEiOnsiZGlyZWN0aW9uIjoxfX19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoibW92ZSIsInRhcmdldCI6eyJ4IjoyLCJ5Ijo0fX0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJtb3ZlIiwidGFyZ2V0Ijp7IngiOjE0LCJ5Ijo0fX0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJoZXgiLCJ4IjoxMiwieSI6NH0sImlkIjozLCJhcmdzIjp7IjEiOnsiY3JlYXR1cmUiOiJTMSIsImNvc3QiOjJ9fX0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJhcnJheSIsImFycmF5IjpbeyJ4IjoxMiwieSI6NH1dfSwiaWQiOjEsImFyZ3MiOnsiMSI6eyJkaXJlY3Rpb24iOjF9fX0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJoZXgiLCJ4IjoxMiwieSI6NX0sImlkIjozLCJhcmdzIjp7IjEiOnt9fX0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJtb3ZlIiwidGFyZ2V0Ijp7IngiOjQsInkiOjR9fSx7ImFjdGlvbiI6ImFiaWxpdHkiLCJ0YXJnZXQiOnsidHlwZSI6ImhleCIsIngiOjgsInkiOjR9LCJpZCI6MywiYXJncyI6eyIxIjp7ImNyZWF0dXJlIjoiQTEiLCJjb3N0IjoyfX19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiaGV4IiwieCI6MTEsInkiOjZ9LCJpZCI6MywiYXJncyI6eyIxIjp7ImNyZWF0dXJlIjoiUDEiLCJjb3N0IjoyfX19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiYXJyYXkiLCJhcnJheSI6W3sieCI6MTEsInkiOjR9LHsieCI6MTAsInkiOjR9LHsieCI6OSwieSI6NH1dfSwiaWQiOjIsImFyZ3MiOnsiMSI6eyJkaXJlY3Rpb24iOjR9fX0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJhcnJheSIsImFycmF5IjpbeyJ4IjoxMSwieSI6NH0seyJ4IjoxMCwieSI6NH0seyJ4Ijo5LCJ5Ijo0fV19LCJpZCI6MywiYXJncyI6eyIxIjp7ImRpcmVjdGlvbiI6NH19fSx7ImFjdGlvbiI6InNraXAifSx7ImFjdGlvbiI6Im1vdmUiLCJ0YXJnZXQiOnsieCI6MTIsInkiOjV9fSx7ImFjdGlvbiI6ImFiaWxpdHkiLCJ0YXJnZXQiOnsidHlwZSI6ImhleCIsIngiOjksInkiOjZ9LCJpZCI6MywiYXJncyI6eyIxIjp7fX19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoibW92ZSIsInRhcmdldCI6eyJ4Ijo2LCJ5Ijo0fX0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJoZXgiLCJ4IjoxNCwieSI6Nn0sImlkIjozLCJhcmdzIjp7IjEiOnsiY3JlYXR1cmUiOiJQNiIsImNvc3QiOjl9fX0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJtb3ZlIiwidGFyZ2V0Ijp7IngiOjEwLCJ5Ijo2fX0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJhcnJheSIsImFycmF5IjpbeyJ4IjoxMSwieSI6Nn1dfSwiaWQiOjEsImFyZ3MiOnsiMSI6eyJkaXJlY3Rpb24iOjF9fX0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJhcnJheSIsImFycmF5IjpbeyJ4IjoxMSwieSI6Nn1dfSwiaWQiOjIsImFyZ3MiOnsiMSI6eyJkaXJlY3Rpb24iOjF9fX0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJoZXgiLCJ4IjoxMCwieSI6Nn0sImlkIjozLCJhcmdzIjp7IjEiOnt9fX0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJhcnJheSIsImFycmF5IjpbeyJ4IjoxMiwieSI6NH0seyJ4IjoxMiwieSI6NX1dfSwiaWQiOjMsImFyZ3MiOnsiMSI6eyJkaXJlY3Rpb24iOjN9fX0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJhcnJheSIsImFycmF5IjpbeyJ4IjoxMiwieSI6NH0seyJ4IjoxMiwieSI6NX1dfSwiaWQiOjIsImFyZ3MiOnsiMSI6eyJkaXJlY3Rpb24iOjMsImhleCI6eyJ4IjoxMiwieSI6NH0sImNob2ljZUluZGV4IjowfX19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiYXJyYXkiLCJhcnJheSI6W3sieCI6MTAsInkiOjZ9XX0sImlkIjozLCJhcmdzIjp7IjEiOnsiZGlyZWN0aW9uIjo0fX19LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiYXJyYXkiLCJhcnJheSI6W3sieCI6MTAsInkiOjN9LHsieCI6MTEsInkiOjN9LHsieCI6OSwieSI6NH0seyJ4IjoxMCwieSI6NH0seyJ4IjoxMSwieSI6NH0seyJ4IjoxMCwieSI6NX0seyJ4IjoxMSwieSI6NX1dfSwiaWQiOjEsImFyZ3MiOnsiMSI6eyJkaXJlY3Rpb24iOjUsImhleCI6eyJ4IjoxMCwieSI6Nn0sImNob2ljZUluZGV4IjoyfX19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiaGV4IiwieCI6OSwieSI6NX0sImlkIjozLCJhcmdzIjp7IjEiOnt9fX0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJtb3ZlIiwidGFyZ2V0Ijp7IngiOjEzLCJ5Ijo1fX0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJjcmVhdHVyZSIsImNyZWEiOjN9LCJpZCI6MSwiYXJncyI6eyIxIjp7fX19LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiY3JlYXR1cmUiLCJjcmVhIjozfSwiaWQiOjIsImFyZ3MiOnsiMSI6e319fSx7ImFjdGlvbiI6InNraXAifSx7ImFjdGlvbiI6Im1vdmUiLCJ0YXJnZXQiOnsieCI6MTAsInkiOjZ9fSx7ImFjdGlvbiI6Im1vdmUiLCJ0YXJnZXQiOnsieCI6MTEsInkiOjZ9fSx7ImFjdGlvbiI6InNraXAifSx7ImFjdGlvbiI6ImFiaWxpdHkiLCJ0YXJnZXQiOnsidHlwZSI6ImFycmF5IiwiYXJyYXkiOlt7IngiOjExLCJ5Ijo2fV19LCJpZCI6MywiYXJncyI6eyIxIjp7ImRpcmVjdGlvbiI6NH19fSx7ImFjdGlvbiI6ImFiaWxpdHkiLCJ0YXJnZXQiOnsidHlwZSI6ImNyZWF0dXJlIiwiY3JlYSI6M30sImlkIjoxLCJhcmdzIjp7IjEiOnt9fX0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJhcnJheSIsImFycmF5IjpbeyJ4IjoxMSwieSI6Nn0seyJ4IjoxMCwieSI6Nn0seyJ4Ijo5LCJ5Ijo2fSx7IngiOjgsInkiOjZ9XX0sImlkIjoyLCJhcmdzIjp7IjEiOnsiZGlyZWN0aW9uIjo0fX19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiYXJyYXkiLCJhcnJheSI6W3sieCI6MTIsInkiOjR9LHsieCI6MTIsInkiOjV9XX0sImlkIjoyLCJhcmdzIjp7IjEiOnsiZGlyZWN0aW9uIjozfX19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiaGV4IiwieCI6OSwieSI6Nn0sImlkIjozLCJhcmdzIjp7IjEiOnt9fX0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJjcmVhdHVyZSIsImNyZWEiOjN9LCJpZCI6MiwiYXJncyI6eyIxIjp7fX19LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiaGV4IiwieCI6MTEsInkiOjV9LCJpZCI6MywiYXJncyI6eyIxIjp7ImNyZWF0dXJlIjoiTDMiLCJjb3N0Ijo2fX19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoiYWJpbGl0eSIsInRhcmdldCI6eyJ0eXBlIjoiYXJyYXkiLCJhcnJheSI6W3sieCI6OSwieSI6NX1dfSwiaWQiOjEsImFyZ3MiOnsiMSI6eyJkaXJlY3Rpb24iOjB9fX0seyJhY3Rpb24iOiJza2lwIn0seyJhY3Rpb24iOiJhYmlsaXR5IiwidGFyZ2V0Ijp7InR5cGUiOiJhcnJheSIsImFycmF5IjpbeyJ4IjoxMSwieSI6Nn0seyJ4IjoxMCwieSI6Nn0seyJ4Ijo5LCJ5Ijo2fSx7IngiOjgsInkiOjZ9XX0sImlkIjoyLCJhcmdzIjp7IjEiOnsiZGlyZWN0aW9uIjo0fX19LHsiYWN0aW9uIjoibW92ZSIsInRhcmdldCI6eyJ4IjoxMCwieSI6Nn19LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9LHsiYWN0aW9uIjoic2tpcCJ9XX0="

however, i am unable to reproduce the kills score. it would be super useful to have a gamelog to test!

@ktiedt ktiedt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The little things that get ya... Good catch

@DreadKnight

Copy link
Copy Markdown
Member

This might be one of those scenarios where the replay logs stops prematurely, anyway, I've played manually to finish the match.

@DreadKnight
DreadKnight merged commit 403c71a into FreezingMoon:master Jun 22, 2018
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants