Skip to content

Fixes #1342 - #1343

Merged
DreadKnight merged 5 commits into
masterfrom
webpack-fixes
Jun 7, 2018
Merged

Fixes #1342#1343
DreadKnight merged 5 commits into
masterfrom
webpack-fixes

Conversation

@ktiedt

@ktiedt ktiedt commented Jun 7, 2018

Copy link
Copy Markdown
Collaborator

This cleans up our webpack stuff a bit and streamlines it as well as properly making Phaser importable (which was needed for the properly inheriting from it later)

@DreadKnight
DreadKnight temporarily deployed to ancientbeast-pr-1343 June 7, 2018 06:06 Inactive
@DreadKnight
DreadKnight temporarily deployed to ancientbeast-pr-1343 June 7, 2018 06:10 Inactive
@DreadKnight

Copy link
Copy Markdown
Member

@ktiedt For some reason it doesn't run on Heroku, there's a log linked right into that "deployed" word above; I'm not sure if it's because it's running on a deprecated Heroku stack, since it did the job for the other stuff... https://dashboard.heroku.com/apps/ancientbeast-pr-1343/activity/builds/e9bcd5a3-64b0-4839-afa2-06e89e94fc1a

@ktiedt

ktiedt commented Jun 7, 2018

Copy link
Copy Markdown
Collaborator Author

weird, it installs and builds fine... but crashes in some other way... this should be fun... :(

@DreadKnight

Copy link
Copy Markdown
Member

@ktiedt I recall last time this happened, was an issue with Heroku itself and they eventually fixed it.
Will have to see somehow it the build works fine in their newer stack thingy perhaps...

@ktiedt
ktiedt temporarily deployed to ancientbeast-pr-1343 June 7, 2018 14:38 Inactive
@ktiedt

ktiedt commented Jun 7, 2018

Copy link
Copy Markdown
Collaborator Author

Yeah I am trying to bump it to the new stack now to test that idea.

@DreadKnight
DreadKnight temporarily deployed to ancientbeast-pr-1343 June 7, 2018 14:45 Inactive
@ktiedt
ktiedt temporarily deployed to ancientbeast-pr-1343 June 7, 2018 14:47 Inactive
@ktiedt

ktiedt commented Jun 7, 2018

Copy link
Copy Markdown
Collaborator Author

This works, removed test change for app.json and it should be safe to upgrade the stack from the dashboard to heroku-16

@DreadKnight

Copy link
Copy Markdown
Member

Noticed, had to delete the deploy for this and create a new one. Will merge in the PR and deploy master branch again to ancientbeast-beta, I guess that should trigger the upgrade to the new stack. Good job!

@DreadKnight
DreadKnight merged commit 6fac6d4 into master Jun 7, 2018
@DreadKnight
DreadKnight deleted the webpack-fixes branch June 7, 2018 15:02
CyberBishop pushed a commit to CyberBishop/AncientBeast that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants