Skip to content

Add Screen Shake to Uncle Fungus & Add .vs to .gitignore file - #1234

Merged
DreadKnight merged 4 commits into
FreezingMoon:masterfrom
medallyon:master
Oct 7, 2017
Merged

Add Screen Shake to Uncle Fungus & Add .vs to .gitignore file#1234
DreadKnight merged 4 commits into
FreezingMoon:masterfrom
medallyon:master

Conversation

@medallyon

Copy link
Copy Markdown

Shake the screen upon Uncle Fungus's ability - "Frogger Jump". Length
of the shake is dependent on how many hexes has been jumped.

Tilman Raendchen added 2 commits October 7, 2017 20:11
Shake the screen upon `Uncle Fungus`'s ability - "Frogger Jump". Length
of the shake is dependent on how many hexes has been jumped.
@medallyon medallyon changed the title Fix #1195 Add Screen Shake to Uncle Fungus & Add .vs to .gitignore file Oct 7, 2017
@DreadKnight

DreadKnight commented Oct 7, 2017

Copy link
Copy Markdown
Member

This is not working for me yet, as Uncle Fungus jumps on same place and the console throws errors:

Uncaught TypeError: Cannot read property 'camera' of undefined
at d.activate (http://localhost:8080/scripts/ancientbeast.js:14872:80)
at activateAbility (http://localhost:8080/scripts/ancientbeast.js:5043:16)
at http://localhost:8080/scripts/ancientbeast.js:5095:6

http://localhost:8080/scripts/ancientbeast.js

@medallyon

Copy link
Copy Markdown
Author

@DreadKnight Weird, because it works just fine for me. :O https://gfycat.com/ZigzagViciousGoa

Tilman Raendchen added 2 commits October 7, 2017 20:34

@medallyon medallyon left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intended to commit .gitignore file via another Pull Request. One could approve this PR and let things be, or I can try creating another Pull Request with this commit.

@DreadKnight
DreadKnight merged commit 62eb801 into FreezingMoon:master Oct 7, 2017
@DreadKnight

Copy link
Copy Markdown
Member

@medallyon no worries about that one. Well done! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants