Add Node 22 setup in Firebase workflows - #348
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 3339fd3): https://fardust--pr348-codex-actualizar-wor-aboec31m.web.app (expires Fri, 13 Jun 2025 00:38:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0f6899045884acfb21b4b818dabc8dfdf9a83d8d |
FarDust
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Firebase workflows to use actions/setup-node@v3 with a node version to support the new Node setup in Firebase deployments.
- Adds a Node setup step in both the pull-request and merge workflows
- Configures npm caching for improved build performance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/firebase-hosting-pull-request.yml | Added Node setup step with node-version '22' |
| .github/workflows/firebase-hosting-merge.yml | Added Node setup step with node-version '22' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/setup-node@v3with Node 22 and npm cache for merge workflowactions/setup-node@v3with Node 22 and npm cache for pull-request workflowTesting
node --versionnpm ci --prefer-offline --no-audit --silent(fails: command interrupted)https://chatgpt.com/codex/tasks/task_e_68421e9601f88325890b1a004ca2cf60