Skip to content

Release 3.6.0#826

Merged
kyonRay merged 19 commits into
FISCO-BCOS:masterfrom
kyonRay:master
Feb 7, 2024
Merged

Release 3.6.0#826
kyonRay merged 19 commits into
FISCO-BCOS:masterfrom
kyonRay:master

Conversation

@kyonRay

@kyonRay kyonRay commented Feb 6, 2024

Copy link
Copy Markdown
Member

No description provided.

@sonarqubecloud

sonarqubecloud Bot commented Feb 6, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

if (supportedVersion.compareTo(EnumNodeVersion.BCOS_3_1_0.toVersionObj()) >= 0) {
fileInfoList = bfsService.list(absolutePath, offset, Common.LS_DEFAULT_COUNT);
} else {
fileInfoList = new Tuple2<>(BigInteger.ZERO, bfsService.list(absolutePath));

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [BFSService.list](1) should be avoided because it has been deprecated.
}
}

public void transferBalance(String[] params) throws Exception {

Check notice

Code scanning / CodeQL

Missing Override annotation

This method overrides [PrecompiledFace.transferBalance](1); it is advisable to add an Override annotation.
}
RetCode retCode = this.balanceService.transfer(from, to, amount, unit);

logger.info("transferBalance: {}, retCode {}", from, retCode);

Check failure

Code scanning / CodeQL

Insertion of sensitive information into log files

This [potentially sensitive information](1) is written to a log file.
}
RetCode retCode = this.balanceService.unregisterCaller(address);

logger.info("unregisterBalanceGovernor: {}, retCode {}", address, retCode);

Check failure

Code scanning / CodeQL

Insertion of sensitive information into log files

This [potentially sensitive information](1) is written to a log file.
@kyonRay kyonRay merged commit 38ee71b into FISCO-BCOS:master Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants