Skip to content

Rework component events#43

Merged
DavidVollmers merged 4 commits into
masterfrom
features/42-focus-blur-events
Dec 14, 2023
Merged

Rework component events#43
DavidVollmers merged 4 commits into
masterfrom
features/42-focus-blur-events

Conversation

@DavidVollmers

Copy link
Copy Markdown
Owner
  • Reworked component events to allow preventing default behaviors
  • Introduce OnBlur and OnFocus events for all FocusComponentBase components
    • Due to this the protected methods OnFocus, OnFocusAsync, OnBlur and OnBlurAsync had to be renamed to OnTargetFocus, etc.

@DavidVollmers

Copy link
Copy Markdown
Owner Author

This will solve #42.

@DavidVollmers DavidVollmers linked an issue Dec 14, 2023 that may be closed by this pull request
@codecov

codecov Bot commented Dec 14, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (8bfcd93) 42.11% compared to head (178d9a0) 41.92%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ackages/Ignis.Components.Web/FocusComponentBase.cs 0.00% 12 Missing ⚠️
...nd/Ignis.Components.HeadlessUI/DisclosureButton.cs 0.00% 1 Missing ⚠️
...lwind/Ignis.Components.HeadlessUI/ListboxOption.cs 0.00% 0 Missing and 1 partial ⚠️
...s/Tailwind/Ignis.Components.HeadlessUI/MenuItem.cs 0.00% 1 Missing ⚠️
...nd/Ignis.Components.HeadlessUI/RadioGroupOption.cs 0.00% 1 Missing ⚠️
...ges/Tailwind/Ignis.Components.HeadlessUI/Switch.cs 0.00% 1 Missing ⚠️
...ckages/Tailwind/Ignis.Components.HeadlessUI/Tab.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   42.11%   41.92%   -0.20%     
==========================================
  Files          82       82              
  Lines        2282     2290       +8     
  Branches      439      441       +2     
==========================================
- Hits          961      960       -1     
- Misses       1185     1193       +8     
- Partials      136      137       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DavidVollmers DavidVollmers merged commit 6768fa4 into master Dec 14, 2023
@DavidVollmers DavidVollmers deleted the features/42-focus-blur-events branch December 14, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to not close dialog on blur

1 participant