Skip to content

Disable retry on 404 response with flags#164

Merged
ibrahimkk-moideen merged 2 commits into
Comcast:mainfrom
asama-ai:disable_404_retry
Jun 2, 2026
Merged

Disable retry on 404 response with flags#164
ibrahimkk-moideen merged 2 commits into
Comcast:mainfrom
asama-ai:disable_404_retry

Conversation

@jj-asama

@jj-asama jj-asama commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

I was testing fishymetrics on a mock redfish server and it was taking too much time. Debugging took me to this part of the code where it sleeps for 2s and retries 404s.
I believe if a BMC is returning 404 any URL, it is not a transient response. If maintainers also think so, we can remove this retry logic unconditionally. For now, created a flag to disable it if needed.

Also did a bit of readability improvements.

@CLAassistant

CLAassistant commented Feb 23, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ibrahimkk-moideen ibrahimkk-moideen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrahimkk-moideen

Copy link
Copy Markdown
Collaborator

@jj-asama could you update your commit to have verified signatures.

@derrick-dacosta

Copy link
Copy Markdown
Collaborator

@jj-asama you need to verify your signature in Github, these instructions can show you how,

https://dev.to/pwd9000/github-commit-verification-using-ssh-2pim

Then you'll need to resubmit your last commit with the verified signature.

Signed-off-by: Jain Johny <jj@asama.ai>
@jj-asama jj-asama force-pushed the disable_404_retry branch from 1b33e68 to 9012028 Compare June 1, 2026 18:50
@jj-asama

jj-asama commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

@jj-asama you need to verify your signature in Github, these instructions can show you how,

https://dev.to/pwd9000/github-commit-verification-using-ssh-2pim

Then you'll need to resubmit your last commit with the verified signature.

Sorry @derrick-dacosta . I somehow missed @ibrahimkk-moideen 's comment. I have pushed it again with signature now

@derrick-dacosta

Copy link
Copy Markdown
Collaborator

@jj-asama if you can just fix the conflicts I will get this merged into main

@jj-asama jj-asama force-pushed the disable_404_retry branch from 18b764c to 1856bd8 Compare June 2, 2026 02:12

@ibrahimkk-moideen ibrahimkk-moideen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibrahimkk-moideen ibrahimkk-moideen merged commit 1deabf6 into Comcast:main Jun 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants