Disable retry on 404 response with flags#164
Merged
Merged
Conversation
Collaborator
|
@jj-asama could you update your commit to have verified signatures. |
Collaborator
|
@jj-asama you need to verify your signature in Github, these instructions can show you how, https://dev.to/pwd9000/github-commit-verification-using-ssh-2pim Then you'll need to resubmit your last commit with the verified signature. |
Signed-off-by: Jain Johny <jj@asama.ai>
1b33e68 to
9012028
Compare
Contributor
Author
Sorry @derrick-dacosta . I somehow missed @ibrahimkk-moideen 's comment. I have pushed it again with signature now |
Collaborator
|
@jj-asama if you can just fix the conflicts I will get this merged into |
18b764c to
1856bd8
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing fishymetrics on a mock redfish server and it was taking too much time. Debugging took me to this part of the code where it sleeps for 2s and retries 404s.
I believe if a BMC is returning 404 any URL, it is not a transient response. If maintainers also think so, we can remove this retry logic unconditionally. For now, created a flag to disable it if needed.
Also did a bit of readability improvements.