Fix integer returns to int32#54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the return types for attributes were only specified as
np.array(dtype=int)ornp.array(dtype=float). Blender itself is specific with data types, returningint32andfloat32from geometry nodes. This mostly wasn't a problem but was causing some platform-specific issues in tests / snapshots.Regardless - we should be explicit and directly match return types to not falsely give the impression about what attribute types Blender is supporting & returning. This does break some snapshots that were printing attribute types as well as data, as well as some floating point rounding that is different between the types.