Add contrib script to enable a mfa device via ykman#559
Merged
Conversation
This script helps to add a yubikey using ykman. See 99designs#558
Merged
|
|
||
| CODE1=$(ykman oath code -s "$SERIAL_NUMBER") | ||
|
|
||
| echo "Waiting 30s before generating a second code" >&2 |
Contributor
There was a problem hiding this comment.
How about just running the command until we get a new code? 30s is the worst case.
Contributor
Author
There was a problem hiding this comment.
It is another option, but having to touch the Yubikey multiple times can be tedious too.
The low-level driver allows to query the key with a timestamp, but ykman does not have that option...
Contributor
There was a problem hiding this comment.
Ah, of course. Thanks for the explanation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script helps to add a yubikey using ykman. See #558