Support formRequestPath option#31
Merged
7nohe merged 2 commits intoMay 19, 2024
Merged
Conversation
Collaborator
Author
|
Hi @7nohe, let me know if there is any concern or further improvements on this :) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Changes
This PR enables users to change FormRequest file path from pre-defined default
app/Http/Requeststo a preferred path with newly added--form-request-pathoption (default:app/Http/Requests). This option helps projects that follow non-default folder structure such as modular monolith.Usage:
The above is an example command in a project with following folder structure
Output
Result of
debug.shSample result of output in modular monolith structure:
Remarks
I wasn't sure which would be better, adding a new option
--form-request-pathor accepting path value for the existing option--form-request. So far, I followed the way of adding a new option. I feel this is simpler and more consistent with the existing options for users.