Skip to content

Fix timestamp flag error when using help#1439

Merged
meatballhat merged 1 commit into
urfave:mainfrom
hmiyado:fix-timestamp-getvalue
Jul 20, 2022
Merged

Fix timestamp flag error when using help#1439
meatballhat merged 1 commit into
urfave:mainfrom
hmiyado:fix-timestamp-getvalue

Conversation

@hmiyado

@hmiyado hmiyado commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • bug

What this PR does / why we need it:

TimestampFlag causes error when using help or -h.

image

The code reproduce this problem is here.
It is same to example in https://cli.urfave.org/v2/#timestamp-flag .

This PR fix this error.

Which issue(s) this PR fixes:

no issue.

Testing

manual testing.

Release Notes

Fix timestamp flag error when using help.

@hmiyado hmiyado requested a review from a team as a code owner July 18, 2022 07:57

@meatballhat meatballhat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @hmiyado!

@meatballhat meatballhat merged commit c8147a4 into urfave:main Jul 20, 2022
@hmiyado hmiyado deleted the fix-timestamp-getvalue branch July 20, 2022 12:51
@meatballhat meatballhat mentioned this pull request Oct 2, 2022
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants