defaultTracingObservationHandler is not ordered as documented - #34216
Closed
ttddyy wants to merge 1 commit into
Closed
defaultTracingObservationHandler is not ordered as documented#34216ttddyy wants to merge 1 commit into
ttddyy wants to merge 1 commit into
Conversation
Signed-off-by: Tadaya Tsuyukubo <tadaya@ttddyy.net>
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
added
type: enhancement
wilkinsona
changed the title
wilkinsona
pushed a commit
that referenced
this pull request
Feb 24, 2023
See gh-34216 Signed-off-by: Tadaya Tsuyukubo <tadaya@ttddyy.net>
Member
|
Thanks very much, @ttddyy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The javadoc on
MicrometerTracingAutoConfiguration.DEFAULT_TRACING_OBSERVATION_HANDLER_ORDERsays it is a@Ordervalue for thedefaultTracingObservationHandlerbean.However, in the code, this constant is not applied to the
defaultTracingObservationHandlerbean definition.This PR specifies the missing
@Orderon thedefaultTracingObservationHandlerbean.